lkml.org 
[lkml]   [2009]   [Mar]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[tip:x86/mm-v2] x86-32: make sure virt_addr_valid() returns false for fixmap addresses
    Commit-ID:  0feca851c1b3cb4ebfa3149144b3d5de0879ebaa
    Gitweb: http://git.kernel.org/tip/0feca851c1b3cb4ebfa3149144b3d5de0879ebaa
    Author: "Jeremy Fitzhardinge" <jeremy@goop.org>
    AuthorDate: Fri, 6 Mar 2009 10:09:26 -0800
    Commit: Ingo Molnar <mingo@elte.hu>
    CommitDate: Sun, 8 Mar 2009 20:03:52 +0100

    x86-32: make sure virt_addr_valid() returns false for fixmap addresses

    I found that virt_addr_valid() was returning true for fixmap addresses.

    I'm not sure whether pfn_valid() is supposed to include this test,
    but there's no harm in being explicit.

    Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
    Cc: Jiri Slaby <jirislaby@gmail.com>
    Cc: Yinghai Lu <yinghai@kernel.org>
    LKML-Reference: <49B166D6.2080505@goop.org>
    Signed-off-by: Ingo Molnar <mingo@elte.hu>


    ---
    arch/x86/mm/ioremap.c | 2 ++
    1 files changed, 2 insertions(+), 0 deletions(-)

    diff --git a/arch/x86/mm/ioremap.c b/arch/x86/mm/ioremap.c
    index 62773ab..62def57 100644
    --- a/arch/x86/mm/ioremap.c
    +++ b/arch/x86/mm/ioremap.c
    @@ -87,6 +87,8 @@ bool __virt_addr_valid(unsigned long x)
    return false;
    if (__vmalloc_start_set && is_vmalloc_addr((void *) x))
    return false;
    + if (x >= FIXADDR_START)
    + return false;
    return pfn_valid((x - PAGE_OFFSET) >> PAGE_SHIFT);
    }
    EXPORT_SYMBOL(__virt_addr_valid);

    \
     
     \ /
      Last update: 2009-03-08 20:31    [W:0.028 / U:0.640 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site