[lkml]   [2009]   [Mar]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [RFC][PATCH] kmemdup_from_user(): introduce
    On Fri, Mar 06, 2009 at 03:04:12PM +0800, Li Zefan wrote:
    > I notice there are many places doing copy_from_user() which follows
    > kmalloc():
    > dst = kmalloc(len, GFP_KERNEL);
    > if (!dst)
    > return -ENOMEM;
    > if (copy_from_user(dst, src, len)) {
    > kfree(dst);
    > return -EFAULT
    > }
    > kmemdup_from_user() is a wrapper of the above code. With this new
    > function, we don't have to write 'len' twice, which can lead to
    > typos/mistakes. It also produces smaller code.

    Name totally sucks, it mixes kernel idiom of allocation with purely
    userspace function.

    > A qucik grep shows 250+ places where kmemdup_from_user() *may* be
    > used. I'll prepare a patchset to do this conversion.


    Let's not add wrapper for every two lines that happen to be used

    BTW, can we drop strstarts() and kzfree() on the same reasoning?

     \ /
      Last update: 2009-03-06 09:17    [W:0.081 / U:14.868 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site