Messages in this thread | | | From | KOSAKI Motohiro <> | Subject | Re: [RFC][PATCH] kmemdup_from_user(): introduce | Date | Fri, 6 Mar 2009 16:37:12 +0900 (JST) |
| |
> > /** > >+ * kmemdup_from_user - duplicate memory region from user space > >+ * > >+ * @src: source address in user space > >+ * @len: number of bytes to copy > >+ * @gfp: GFP mask to use > >+ */ > >+void *kmemdup_from_user(const void __user *src, size_t len, gfp_t gfp) > >+{ > >+ void *p; > >+ > >+ p = kmalloc_track_caller(len, gfp); > > > Well, you use kmalloc_track_caller, instead of kmalloc as you showed > above. :) Why don't you mention this?
kmalloc() wrapper function must use kmalloc_track_caller(). his code is right.
if not, kmalloc tracking feature is breaked.
| |