lkml.org 
[lkml]   [2009]   [Mar]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v10 2/7] PCI: restore saved SR-IOV state
    On Fri, Feb 20, 2009 at 02:54:43PM +0800, Yu Zhao wrote:
    > Signed-off-by: Yu Zhao <yu.zhao@intel.com>

    It needs a changelog ...

    > +static void sriov_restore_state(struct pci_dev *dev)
    > +{
    [...]
    > +}
    > +
    [...]
    > +/**
    > + * pci_restore_iov_state - restore the state of the IOV capability
    > + * @dev: the PCI device
    > + */
    > +void pci_restore_iov_state(struct pci_dev *dev)
    > +{
    > + if (dev->sriov)
    > + sriov_restore_state(dev);
    > +}

    Apart from the design pattern I mentioned in my previous email also
    appearing here, I see no problems with this patch.

    --
    Matthew Wilcox Intel Open Source Technology Centre
    "Bill, look, we understand that you're interested in selling us this
    operating system, but compare it to ours. We can't possibly take such
    a retrograde step."


    \
     
     \ /
      Last update: 2009-03-06 21:13    [W:0.020 / U:124.752 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site