lkml.org 
[lkml]   [2009]   [Mar]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: commit "radeonfb: Fix resume from D3Cold on some platforms" breaks resume from RAM on PowerBook
    On Fri, Mar 06, 2009 at 04:50:29PM +1100, Benjamin Herrenschmidt wrote:
    >
    > > As already said in an earlier mail, this does not make any difference. I
    > > now ran some more tests:
    > >
    > > -> with ppc32_defconfig: same results, resume with your commit is
    > > broken, I did not yet test if reverting the commit fixes resume.
    > > Please tell me if you are interested in this result.
    > > -> with a minimal config (attached): resume does not work at all with or
    > > without your commit. I suspect this is another bug with the same
    > > symptoms.
    > >
    > > If you have any ideas, I would be happy to do further tests. I could
    > > also send you my compiles kernel (as a Debian package or a tar file) or
    > > you could send me your working kernel image to see if it also works for
    > > me.
    >
    > I think that .config fails due to the lack of CPU_FREQ support. I think
    > I remember that specifically this powerbook model boots at low speed and
    > fails to resume if not suspended at high speed. The cpufreq driver for
    > powermacs knows about that and ramps up the frequency before suspend.
    >
    > Can you give that a try ?

    OK, with CPU_FREQ enabled I have the same results as with
    ppc32_defconfig or my full config. It fails to resume with your commit
    and it works if I revert that commit.

    >
    > In fact I verified on mine that your minimum config fails the same way
    > you described but it works when I re-enable cpufreq support.

    So you are able to resume with my minimal config + CPU_FREQ? This would
    be really strange if it is really the exact same model.

    To verify if we really have the same model I included some data below. I
    also included the gcc and binutils versions.

    Please tell me if you have any further ideas on what to test.

    Gaudenz


    /proc/cpuinfo:
    processor : 0
    cpu : 7447A, altivec supported
    clock : 1666.666000MHz
    revision : 1.5 (pvr 8003 0105)
    bogomips : 33.15
    timebase : 8320000
    platform : PowerMac
    model : PowerBook5,8
    machine : PowerBook5,8
    motherboard : PowerBook5,8 MacRISC3 Power Macintosh
    detected as : 287 (PowerBook G4 15")
    pmac flags : 00000019
    L2 cache : 512K unified
    pmac-generation : NewWorld
    Memory : 1536 MB

    lspci -n:
    0000:00:0b.0 0600: 106b:0066
    0000:00:10.0 0300: 1002:4e50
    0001:10:0b.0 0600: 106b:0067
    0001:10:11.0 0280: 14e4:4318 (rev 02)
    0001:10:14.0 0607: 104c:ac56
    0001:10:15.0 0c03: 1033:0035 (rev 43)
    0001:10:15.1 0c03: 1033:0035 (rev 43)
    0001:10:15.2 0c03: 1033:00e0 (rev 04)
    0001:10:17.0 ff00: 106b:003e
    0002:24:0b.0 0600: 106b:0068
    0002:24:0d.0 ff00: 106b:0069
    0002:24:0e.0 0c00: 106b:006a
    0002:24:0f.0 0200: 106b:006b

    gcc --version:
    gcc (Debian 4.3.3-5) 4.3.3

    ld --version:
    GNU ld (GNU Binutils for Debian) 2.19.1
    --
    Ever tried. Ever failed. No matter.
    Try again. Fail again. Fail better.
    ~ Samuel Beckett ~


    \
     
     \ /
      Last update: 2009-03-06 10:13    [W:0.025 / U:91.040 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site