lkml.org 
[lkml]   [2009]   [Mar]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 0/3] xfs: fix sparse warnings
Date

On Mar 4, 2009, at 12:33 PM, Hannes Eder wrote:

> The following series fixes a fair amount of the remaining sparse
> warnings in fs/xfs with !CONFIG_XFS_DEBUG.
>
> With CONFIG_XFS_DEBUG we still got alot of "Should it be static?"
> warnings, but that's a different issue.

Looks good to me with the changes Christoph pointed out.
I'll push it in. Thanks.

Reviewed-by: Felix Blyakher <felixb@sgi.com>

>
>
> ---
> Hannes Eder (3):
> xfs: include header files for prototypes
> xfs: make symbols static
> xfs: move declaration to header file
>
> fs/xfs/linux-2.6/xfs_ioctl.c | 1 +
> fs/xfs/linux-2.6/xfs_super.c | 6 +++---
> fs/xfs/support/debug.c | 1 +
> fs/xfs/xfs_bmap.c | 2 +-
> fs/xfs/xfs_da_btree.h | 1 +
> fs/xfs/xfs_dir2.c | 2 --
> fs/xfs/xfs_dir2_leaf.c | 2 +-
> 7 files changed, 8 insertions(+), 7 deletions(-)



\
 
 \ /
  Last update: 2009-03-05 18:47    [W:0.060 / U:0.248 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site