Messages in this thread |  | | | From | Bartlomiej Zolnierkiewicz <> | | Subject | Re: [PATCH 3/3] ide-{cd,floppy}: do not map all cmds to an sg | | Date | Thu, 5 Mar 2009 17:52:41 +0100 |
| |
On Thursday 05 March 2009, Borislav Petkov wrote: > Hi, > > > Unrelated to the original issue that the patch tries to fix > > (sg mapping no data commands which OOPS-es w/ DEBUG_VIRTUAL=y): > > - moving ide_init_sg_cmd()+ide_map_sg() to ide_issue_pc() > > - converting the code to use blk_rq_bytes() > > aah, ok, now I could get exactly what you meant :). However, (!) ide-floppy is > potentially broken in the same way for data-less cmds since we unconditionally
Indeed, you are right but it seems that this is not a new problem.
Wait... it makes things "worse" as there should have been 3 patches: (IOW _three_ patchpoints! ;):
- ide-cd fix for problematic patch - ide-floppy fix for mainline - ide-atapi cleanup for pata tree
Thanks, Bart
|  |