lkml.org 
[lkml]   [2009]   [Mar]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[RFC][PATCH 01/11] kill '_data' in cr_hdr_fd_data name
    From
    Date

    The 'cr_hdr_fd_data' name is too long for me. Adding data
    at the end doesn't clarify anything in its use which makes
    it a waste of space. Kill it.

    Signed-off-by: Dave Hansen <dave@linux.vnet.ibm.com>
    ---

    linux-2.6.git-dave/checkpoint/ckpt_file.c | 2 +-
    linux-2.6.git-dave/checkpoint/rstr_file.c | 2 +-
    linux-2.6.git-dave/include/linux/checkpoint_hdr.h | 2 +-
    3 files changed, 3 insertions(+), 3 deletions(-)

    diff -puN checkpoint/ckpt_file.c~f49811bdfd2cde1dfa766f38cc017a5cdd8be75e checkpoint/ckpt_file.c
    --- linux-2.6.git/checkpoint/ckpt_file.c~f49811bdfd2cde1dfa766f38cc017a5cdd8be75e 2009-03-05 08:36:59.000000000 -0800
    +++ linux-2.6.git-dave/checkpoint/ckpt_file.c 2009-03-05 08:36:59.000000000 -0800
    @@ -76,7 +76,7 @@ int cr_scan_fds(struct files_struct *fil
    static int cr_write_fd_data(struct cr_ctx *ctx, struct file *file, int parent)
    {
    struct cr_hdr h;
    - struct cr_hdr_fd_data *hh = cr_hbuf_get(ctx, sizeof(*hh));
    + struct cr_hdr_fd *hh = cr_hbuf_get(ctx, sizeof(*hh));
    struct dentry *dent = file->f_dentry;
    struct inode *inode = dent->d_inode;
    enum fd_type fd_type;
    diff -puN checkpoint/rstr_file.c~f49811bdfd2cde1dfa766f38cc017a5cdd8be75e checkpoint/rstr_file.c
    --- linux-2.6.git/checkpoint/rstr_file.c~f49811bdfd2cde1dfa766f38cc017a5cdd8be75e 2009-03-05 08:36:59.000000000 -0800
    +++ linux-2.6.git-dave/checkpoint/rstr_file.c 2009-03-05 08:36:59.000000000 -0800
    @@ -71,7 +71,7 @@ static int cr_attach_get_file(struct fil
    static int
    cr_read_fd_data(struct cr_ctx *ctx, struct files_struct *files, int rparent)
    {
    - struct cr_hdr_fd_data *hh = cr_hbuf_get(ctx, sizeof(*hh));
    + struct cr_hdr_fd *hh = cr_hbuf_get(ctx, sizeof(*hh));
    struct file *file;
    int parent, ret;
    int fd = 0; /* pacify gcc warning */
    diff -puN include/linux/checkpoint_hdr.h~f49811bdfd2cde1dfa766f38cc017a5cdd8be75e include/linux/checkpoint_hdr.h
    --- linux-2.6.git/include/linux/checkpoint_hdr.h~f49811bdfd2cde1dfa766f38cc017a5cdd8be75e 2009-03-05 08:36:59.000000000 -0800
    +++ linux-2.6.git-dave/include/linux/checkpoint_hdr.h 2009-03-05 08:36:59.000000000 -0800
    @@ -137,7 +137,7 @@ enum fd_type {
    CR_FD_DIR,
    };

    -struct cr_hdr_fd_data {
    +struct cr_hdr_fd {
    __u16 fd_type;
    __u16 f_mode;
    __u32 f_flags;
    _

    \
     
     \ /
      Last update: 2009-03-05 17:41    [W:0.028 / U:1.232 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site