| Date | Thu, 5 Mar 2009 17:23:29 +0100 | From | Oleg Nesterov <> | Subject | Re: [v2 PATCH 4/4] timers: logic to enable timer migration. |
| |
On 03/04, Arun R Bharadwaj wrote: > > +++ linux.trees.git/kernel/sched.c > @@ -4009,6 +4009,11 @@ static struct { > .load_balancer = ATOMIC_INIT(-1), > }; > > +inline int get_nohz_load_balancer(void)
inline?
> +{ > + return atomic_read(&nohz.load_balancer); > +}
Shouldn't we reset .load_balancer when this CPU is CPU_DOWN'ed ? Otherwise the timer can migrate to the dead CPU.
Oleg.
|