[lkml]   [2009]   [Mar]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH -mm 3/6] slub: introduce __kfree_rcu
Christoph Lameter wrote:
> On Tue, 3 Mar 2009, Lai Jiangshan wrote:
>> +
>> +void __kfree_rcu(const void *x, struct rcu_head *rcu)
>> +{
>> + call_rcu(rcu, kfree_rcu_callback);
>> +}
>> +EXPORT_SYMBOL(__kfree_rcu);
>> +
> The parameter x is unused why require it? I see that SLOB needs it. Cant
> you do a similar trick as in SLUB just calculating the start address of
> the object from the rcu address?

The first parameter of __kfree_rcu() is unused in slab,slub,slqb.
(I used it before, for CONFIG_SLUB_DEBUG=y ...etc. But I found
these debugging code is needless)

Object sizes of the memory objects in slob's kmalloc-slab are various.
We hardly calculate the start address of the object from the rcu address.


 \ /
  Last update: 2009-03-05 02:23    [W:0.029 / U:7.976 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site