lkml.org 
[lkml]   [2009]   [Mar]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [v2 PATCH 4/4] timers: logic to enable timer migration.
    From
    Date
    On Wed, 2009-03-04 at 17:49 +0530, Arun R Bharadwaj wrote:
    > @@ -649,6 +650,16 @@ __mod_timer(struct timer_list *timer, un
    >
    > new_base = __get_cpu_var(tvec_bases);
    >
    > + current_cpu = smp_processor_id();
    > + preferred_cpu = get_nohz_load_balancer();
    > + if (enable_timer_migration && !tbase_get_pinned(timer->base)
    > &&
    > + idle_cpu(current_cpu) && preferred_cpu != -1)
    > {
    > + new_base = per_cpu(tvec_bases, preferred_cpu);
    > + timer_set_base(timer, new_base);
    > + timer->expires = expires;
    > + internal_add_timer(new_base, timer);
    > + goto out_unlock;
    > + }

    Are you sure this compiles w/ CONFIG_SMP=n ? It looks like
    enable_timer_migration wouldn't exist in that case, but the chunks your
    adding in the timer code are still using it.

    Daniel



    \
     
     \ /
      Last update: 2009-03-04 17:35    [from the cache]
    ©2003-2014 Jasper Spaans. Advertise on this site