Messages in this thread | | | Date | Mon, 30 Mar 2009 12:42:11 +0200 | From | Martin Schwidefsky <> | Subject | Re: [PATCH UPDATED] percpu: use dynamic percpu allocator as the default percpu allocator |
| |
On Mon, 30 Mar 2009 19:07:44 +0900 Tejun Heo <tj@kernel.org> wrote:
> Okay, this should keep s390 and alpha working till proper solution is > found. Martin, can you please verify? Ingo, please feel free to push > this upstream (or -next) once Martin acks.
Looks good, everything compiles and the static per-cpu variables are resolved via GOTENT:
Acked-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
For the proper solution, the easiest fix is imho to define a variant of SHIFT_PERCPU_PTR. The macro is currently used for dynamic pointers and for per-cpu symbols. We only want to use the GOTENT indirection for per-cpu symbols. So why don't we split it into 1) SHIFT_PERCPU_SYMBOL for per-cpu symbols and 2) SHIFT_PERCPU_PTR for dynamically allocated pointers? For s390 the first would be the current SHIFT_PERCPU_PTR macro, the second would be a simple RELOC_HIDE. The patch would be really short ..
-- blue skies, Martin.
"Reality continues to ruin my life." - Calvin.
| |