lkml.org 
[lkml]   [2009]   [Mar]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Regression caused by commit "netfilter: iptables: lock free counters"
On Mon, 30 Mar 2009 14:08:08 +0200
Patrick McHardy <kaber@trash.net> wrote:

> Roman Mindalev wrote:
> > On Mon, 30 Mar 2009 09:32:51 +0200
> > Eric Dumazet <dada1@cosmosbay.com> wrote:
> >
> >> Could you try following patch ?
> >>
> >> [PATCH] netfilter: use rcu_read_bh() in ipt_do_table()
> >>
> >> Commit 784544739a25c30637397ace5489eeb6e15d7d49
> >> (netfilter: iptables: lock free counters) forgot to disable BH
> >> in arpt_do_table(), ipt_do_table() and ip6t_do_table()
> >>
> >> Use rcu_read_lock_bh() instead of rcu_read_lock() cures the problem.
> >>
> >> Reported-and-bisected-by: Roman Mindalev <r000n@r000n.net>
> >> Signed-off-by: Eric Dumazet <dada1@cosmosbay.com>
> >> ---
> >
> > 2.6.29-git4 and 2.6.29-git6 both works fine for me with this patch.
> > Thanks, Eric!
>
> Thanks indeed Eric :) Dave, please apply.
>
> Acked-by: Patrick McHardy <kaber@trash.net>
>
>
Acked-by: Stephen Hemminger <shemminger@vyatta.com>

The original version had rcu_read_lock_bh() but someone (not sure who)
talked me into removing it.


\
 
 \ /
  Last update: 2009-03-30 16:59    [W:0.051 / U:0.480 seconds]
©2003-2014 Jasper Spaans. Advertise on this site