lkml.org 
[lkml]   [2009]   [Mar]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/5] ext3: call blkdev_issue_flush on fsync()
    Fernando Luis Vázquez Cao wrote:
    > Jeff Garzik wrote:
    >> Fernando Luis Vázquez Cao wrote:
    >>> To ensure that bits are truly on-disk after an fsync or fdatasync, we
    >>> should force a disk flush explicitly when there is dirty data/metadata
    >>> and the journal didn't emit a write barrier (either because metadata is
    >>> not being synched or barriers are disabled).
    >>>
    >>> Signed-off-by: Fernando Luis Vazquez Cao <fernando@oss.ntt.co.jp>
    >>
    >> Your patches do not seem to propagate the issue-flush error code, even
    >> when it is easily available.
    >
    > Oops... you are right. I will fix that.

    I reflected your comments in the new version of the patch set.While at
    it I also modified the respective reiserfs and xfs fsync functions so
    that, at least to some extent,they propagate the issue-flush error code.

    I'll be replying to this email with the new patches.

    Thanks,

    Fernando
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2009-03-30 14:07    [W:4.097 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site