lkml.org 
[lkml]   [2009]   [Mar]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] crc32: remove useless __pure modifier from functions
From
On Mon, Mar 2, 2009 at 5:42 PM, Thiago Galesi <thiagogalesi@gmail.com> wrote:
>>
>> Hmm. They're not marked as pure in the header files. Does GCC look it up
>> from the object file or something for this...?
>
> I just tested this, the answer is No :(
>
> It only works if it's marked in the header. But when it's marked, it
> works, and redundant calls are optimized.

Did you see any change in size of your kernel with this annotation? It
didn't seem to have any effect as far as I could tell.

There are a number of functions in lib/ code that could be marked
__pure or __attribute_const__ but I'm not sure if it's worth the
effort, for my compiler (gcc 4.2) at least.


\
 
 \ /
  Last update: 2009-03-03 10:35    [from the cache]
©2003-2011 Jasper Spaans