| | Date | Mon, 30 Mar 2009 11:26:20 +0900 | | From | Yoshihiro Shimoda <> | | Subject | Re: [PATCH 14/58] move sh_flctl's probe function to .devinit.text |
| |
Acked-by: Yoshihiro Shimoda <shimoda.yoshihiro@renesas.com>
Thanks, Yoshihiro Shimoda
Uwe Kleine-König wrote: > A pointer to flctl_probe is passed to the core via > platform_driver_register and so the function must not disappear when the > .init sections are discarded. Otherwise (if also having HOTPLUG=y) > unbinding and binding a device to the driver via sysfs will result in an > oops as does a device being registered late. > > An alternative to this patch is using platform_driver_probe instead of > platform_driver_register plus removing the pointer to the probe function > from the struct platform_driver. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > Cc: Yoshihiro Shimoda <shimoda.yoshihiro@renesas.com> > Cc: David Woodhouse <David.Woodhouse@intel.com> > Cc: Paul Mundt <lethal@linux-sh.org> > Cc: Andrew Morton <akpm@linux-foundation.org> > --- > drivers/mtd/nand/sh_flctl.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/mtd/nand/sh_flctl.c b/drivers/mtd/nand/sh_flctl.c > index 821acb0..fdc0e4e 100644 > --- a/drivers/mtd/nand/sh_flctl.c > +++ b/drivers/mtd/nand/sh_flctl.c > @@ -763,7 +763,7 @@ static int flctl_chip_init_tail(struct mtd_info *mtd) > return 0; > } > > -static int __init flctl_probe(struct platform_device *pdev) > +static int __devinit flctl_probe(struct platform_device *pdev) > { > struct resource *res; > struct sh_flctl *flctl;
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|