| Date | Sat, 28 Mar 2009 11:45:52 +0100 | From | Ralf Baechle <> | Subject | Re: [PATCH 44/58] move sgiseeq's probe function to .devinit.text |
| |
On Sat, Mar 28, 2009 at 12:27:05AM +0100, Uwe Kleine-König wrote:
> A pointer to sgiseeq_probe is passed to the core via > platform_driver_register and so the function must not disappear when the > .init sections are discarded. Otherwise (if also having HOTPLUG=y) > unbinding and binding a device to the driver via sysfs will result in an > oops as does a device being registered late. > > An alternative to this patch is using platform_driver_probe instead of > platform_driver_register plus removing the pointer to the probe function > from the struct platform_driver. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > Cc: Wang Chen <wangchen@cn.fujitsu.com> > Cc: David S. Miller <davem@davemloft.net> > Cc: Andrew Morton <akpm@linux-foundation.org> > Cc: Jeff Garzik <jgarzik@redhat.com> > Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de> > Cc: Ralf Baechle <ralf@linux-mips.org>
Acked-by: Ralf Baechle <ralf@linux-mips.org>
Ralf -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|