Messages in this thread | | | Date | Sat, 28 Mar 2009 09:39:10 +0100 | Subject | Re: [PATCH 25/58] move macsonic's probe function to .devinit.text | From | Geert Uytterhoeven <> |
| |
2009/3/28 Uwe Kleine-König <u.kleine-koenig@pengutronix.de>: > A pointer to mac_sonic_probe is passed to the core via > platform_driver_register and so the function must not disappear when the > .init sections are discarded. Otherwise (if also having HOTPLUG=y) > unbinding and binding a device to the driver via sysfs will result in an > oops as does a device being registered late. > > An alternative to this patch is using platform_driver_probe instead of > platform_driver_register plus removing the pointer to the probe function > from the struct platform_driver. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > Cc: Jeff Garzik <jgarzik@redhat.com> > Cc: David S. Miller <davem@davemloft.net> > Cc: Finn Thain <fthain@telegraphics.com.au> > Cc: Geert Uytterhoeven <geert@linux-m68k.org> > Cc: Andrew Morton <akpm@linux-foundation.org> > --- > drivers/net/macsonic.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/net/macsonic.c b/drivers/net/macsonic.c > index 527166e..d4f913b 100644 > --- a/drivers/net/macsonic.c > +++ b/drivers/net/macsonic.c > @@ -555,7 +555,7 @@ static int __init mac_nubus_sonic_probe(struct net_device *dev) > return macsonic_init(dev); > } > > -static int __init mac_sonic_probe(struct platform_device *pdev) > +static int __devinit mac_sonic_probe(struct platform_device *pdev) > { > struct net_device *dev; > struct sonic_local *lp;
mac_{onboard,nubus}_sonic_probe() (called by mac_sonic_probe()) have the same problem.
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |