lkml.org 
[lkml]   [2009]   [Mar]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [git-pull -tip] x86: include inverse Xmas tree patches
On Sat, 28 Mar 2009, H. Peter Anvin wrote:
> Sam Ravnborg wrote:
> >
> > Ordering include based on length of line minimize the
> > risk of merge conflicts.
> > If people just add new includes in the bottom of the list you
> > are certain that a merge conflit happens.
> >
> > This scheme is starting to be used in several places with the
> > primary advocates being David Miller and Ingo.
> >
> > It is getting used both for includes _and_ for local variables.
> >
>
> Personally I'd prefer alphabetic order, sorting based on length isn't a
> complete ordering. Nearly all editors can sort alphabetically at the
> push of a key.

I'd prefer if somebody would sit down and write a tool to analyse the
include hell instead of manually shuffling crap around to avoid
trivial merge conflicts. I have cleaned up enough stuff in the x86
merger myself where I was able to cut the number of includes at least
in half just by staring at the gcc intermediate files. We could do
better and automate the analysis so we get down to a handful of
includes instead of including the world and more.

Also there are lots of occasions where includes in header files can be
avoided completely by a single line forward declaration of struct foo
instead of adding the include, which drags in another five.

Thanks,

tglx


\
 
 \ /
  Last update: 2009-03-29 00:41    [W:0.066 / U:0.500 seconds]
©2003-2014 Jasper Spaans. Advertise on this site