| Date | Sat, 28 Mar 2009 11:21:49 +0300 | From | Evgeniy Polyakov <> | Subject | Re: [PATCH 31/58] move omap_hdq's probe function to .devinit.text |
| |
Hi Uwe.
On Sat, Mar 28, 2009 at 12:26:52AM +0100, Uwe Kleine-König (u.kleine-koenig@pengutronix.de) wrote: > A pointer to omap_hdq_probe is passed to the core via > platform_driver_register and so the function must not disappear when the > .init sections are discarded. Otherwise (if also having HOTPLUG=y) > unbinding and binding a device to the driver via sysfs will result in an > oops as does a device being registered late. > > An alternative to this patch is using platform_driver_probe instead of > platform_driver_register plus removing the pointer to the probe function > from the struct platform_driver.
I wonder if it can be hotplugged, but for the consistency it looks good.
-- Evgeniy Polyakov -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|