Messages in this thread | | | Date | Fri, 27 Mar 2009 00:29:20 -0700 (PDT) | Subject | Re: [PATCH] af_rose/x25: Sanity check the maximum user frame size | From | David Miller <> |
| |
From: Alan Cox <alan@lxorguk.ukuu.org.uk> Date: Thu, 26 Mar 2009 21:58:51 +0000
> Otherwise we can wrap the sizes and end up sending garbage. > > Closes #10423 > > Signed-off-by: Alan Cox <alan@lxorguk.ukuu.org.uk>
Applied, but:
> - /* Build a packet */ > + /* Build a packet - the conventional user limit is 236 bytes. We can > + do ludicrously large NetROM frames but must not overflow */ > + if (len > 65536) > + return -EMSGSIZE; > + ^^^^^^^^^^^^^
please fix the tab monster :-) Or, alternatively, check the patch either with GIT's automatic checks (or using checkpatch.pl if you haven't eaten recently)
| |