lkml.org 
[lkml]   [2009]   [Mar]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] af_rose/x25: Sanity check the maximum user frame size
From
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
Date: Thu, 26 Mar 2009 21:58:51 +0000

> Otherwise we can wrap the sizes and end up sending garbage.
>
> Closes #10423
>
> Signed-off-by: Alan Cox <alan@lxorguk.ukuu.org.uk>

Applied, but:

> - /* Build a packet */
> + /* Build a packet - the conventional user limit is 236 bytes. We can
> + do ludicrously large NetROM frames but must not overflow */
> + if (len > 65536)
> + return -EMSGSIZE;
> +
^^^^^^^^^^^^^

please fix the tab monster :-) Or, alternatively, check the patch
either with GIT's automatic checks (or using checkpatch.pl if you
haven't eaten recently)



\
 
 \ /
  Last update: 2009-03-27 08:33    [W:0.777 / U:0.000 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site