[lkml]   [2009]   [Mar]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    Subject[PATCH 20/58] move hp680-bl's probe function to .devinit.text
    A pointer to hp680bl_probe is passed to the core via
    platform_driver_register and so the function must not disappear when the
    .init sections are discarded. Otherwise (if also having HOTPLUG=y)
    unbinding and binding a device to the driver via sysfs will result in an
    oops as does a device being registered late.

    An alternative to this patch is using platform_driver_probe instead of
    platform_driver_register plus removing the pointer to the probe function
    from the struct platform_driver.

    Signed-off-by: Uwe Kleine-König <>
    Cc: Akinobu Mita <>
    Cc: Richard Purdie <>
    Cc: Paul Mundt <>
    Cc: Kristoffer Ericson <>
    Cc: Andrew Morton <>
    Cc: Andriy Skulysh <>
    Cc: Antonino Daplas <>
    drivers/video/backlight/hp680_bl.c | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/drivers/video/backlight/hp680_bl.c b/drivers/video/backlight/hp680_bl.c
    index 5be55a2..7fb4eef 100644
    --- a/drivers/video/backlight/hp680_bl.c
    +++ b/drivers/video/backlight/hp680_bl.c
    @@ -103,7 +103,7 @@ static struct backlight_ops hp680bl_ops = {
    .update_status = hp680bl_set_intensity,

    -static int __init hp680bl_probe(struct platform_device *pdev)
    +static int __devinit hp680bl_probe(struct platform_device *pdev)
    struct backlight_device *bd;

    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2009-03-28 00:47    [W:0.022 / U:1.900 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site