| From | Uwe Kleine-König <> | Subject | [PATCH 27/58] move mmci-omap's probe function to .devinit.text | Date | Sat, 28 Mar 2009 00:26:48 +0100 |
| |
A pointer to mmc_omap_probe is passed to the core via platform_driver_register and so the function must not disappear when the .init sections are discarded. Otherwise (if also having HOTPLUG=y) unbinding and binding a device to the driver via sysfs will result in an oops as does a device being registered late.
An alternative to this patch is using platform_driver_probe instead of platform_driver_register plus removing the pointer to the probe function from the struct platform_driver.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Cc: Grazvydas Ignotas <notasas@gmail.com> Cc: Pierre Ossman <drzeus-mmc@drzeus.cx> Cc: David Brownell <dbrownell@users.sourceforge.net> Cc: Tony Lindgren <tony@atomide.com> Cc: Russell King <rmk+kernel@arm.linux.org.uk> Cc: Paul Walmsley <paul@pwsan.com> Cc: Jarkko Lavinen <jarkko.lavinen@nokia.com> Cc: Hiroshi DOYU <Hiroshi.DOYU@nokia.com> Cc: Kyungmin Park <kyungmin.park@samsung.com> Cc: Carlos Eduardo Aguiar <carlos.aguiar@indt.org.br> Cc: Andrew Morton <akpm@linux-foundation.org> --- drivers/mmc/host/omap.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/mmc/host/omap.c b/drivers/mmc/host/omap.c index 67d7b7f..33bf49f 100644 --- a/drivers/mmc/host/omap.c +++ b/drivers/mmc/host/omap.c @@ -1394,7 +1394,7 @@ static void mmc_omap_remove_slot(struct mmc_omap_slot *slot) mmc_free_host(mmc); } -static int __init mmc_omap_probe(struct platform_device *pdev) +static int __devinit mmc_omap_probe(struct platform_device *pdev) { struct omap_mmc_platform_data *pdata = pdev->dev.platform_data; struct mmc_omap_host *host = NULL; -- 1.6.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|