lkml.org 
[lkml]   [2009]   [Mar]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 22/58] move jazzsonic's probe function to .devinit.text
    Date
    A pointer to jazz_sonic_probe is passed to the core via
    platform_driver_register and so the function must not disappear when the
    .init sections are discarded. Otherwise (if also having HOTPLUG=y)
    unbinding and binding a device to the driver via sysfs will result in an
    oops as does a device being registered late.

    An alternative to this patch is using platform_driver_probe instead of
    platform_driver_register plus removing the pointer to the probe function
    from the struct platform_driver.

    Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
    Cc: Ralf Baechle <ralf@linux-mips.org>
    Cc: Jeff Garzik <jeff@garzik.org>
    Cc: David S. Miller <davem@davemloft.net>
    Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
    Cc: Finn Thain <fthain@telegraphics.com.au>
    Cc: Geert Uytterhoeven <geert@linux-m68k.org>
    Cc: Andrew Morton <akpm@linux-foundation.org>
    ---
    drivers/net/jazzsonic.c | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/drivers/net/jazzsonic.c b/drivers/net/jazzsonic.c
    index 14248cf..3695f2d 100644
    --- a/drivers/net/jazzsonic.c
    +++ b/drivers/net/jazzsonic.c
    @@ -204,7 +204,7 @@ out:
    * Probe for a SONIC ethernet controller on a Mips Jazz board.
    * Actually probing is superfluous but we're paranoid.
    */
    -static int __init jazz_sonic_probe(struct platform_device *pdev)
    +static int __devinit jazz_sonic_probe(struct platform_device *pdev)
    {
    struct net_device *dev;
    struct sonic_local *lp;
    --
    1.6.2
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2009-03-28 00:37    [W:0.023 / U:29.780 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site