lkml.org 
[lkml]   [2009]   [Mar]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 1/8] mm: disable preemption in apply_to_pte_range
    Date
    From: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>

    Impact: bugfix

    Lazy mmu mode needs preemption disabled, so if we're apply to
    init_mm (which doesn't require any pte locks), then explicitly
    disable preemption. (Do it unconditionally after checking we've
    successfully done the allocation to simplify the error handling.)

    Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
    ---
    mm/memory.c | 2 ++
    1 files changed, 2 insertions(+), 0 deletions(-)

    diff --git a/mm/memory.c b/mm/memory.c
    index ef11ac6..27f8677 100644
    --- a/mm/memory.c
    +++ b/mm/memory.c
    @@ -1722,6 +1722,7 @@ static int apply_to_pte_range(struct mm_struct *mm, pmd_t *pmd,

    BUG_ON(pmd_huge(*pmd));

    + preempt_disable();
    arch_enter_lazy_mmu_mode();

    token = pmd_pgtable(*pmd);
    @@ -1733,6 +1734,7 @@ static int apply_to_pte_range(struct mm_struct *mm, pmd_t *pmd,
    } while (pte++, addr += PAGE_SIZE, addr != end);

    arch_leave_lazy_mmu_mode();
    + preempt_enable();

    if (mm != &init_mm)
    pte_unmap_unlock(pte-1, ptl);
    --
    1.6.0.6


    \
     
     \ /
      Last update: 2009-03-27 19:05    [W:0.019 / U:245.552 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site