Messages in this thread | | | Date | Fri, 27 Mar 2009 12:35:53 +0100 | From | Pavel Machek <> | Subject | Re: TOMOYO in linux-next |
| |
On Fri 2009-03-27 11:46:42, James Morris wrote: > On Fri, 27 Mar 2009, Pavel Machek wrote: > > > Hi! > > > > > As for the rest of the feedback, please work with the developers to fix > > > any bugs or lack of documentation. > > > > Apparently not even its user<->kernel interface was reviewed. This > > violates "one value per file in sysfs": > > > > [root@tomoyo]# cat /sys/kernel/security/tomoyo/meminfo > > Shared: 61440 > > Private: 69632 > > Dynamic: 768 > > Total: 131840 > > > > You can set memory quota by writing to this file. > > (Example) > > [root@tomoyo]# echo Shared: 2097152 > /sys/kernel/security/tomoyo/meminfo > > [root@tomoyo]# echo Private: 2097152 > /sys/kernel/security/tomoyo/meminfo > > This is not sysfs, it's securityfs, with their documentation showing it > mounted on /sys.
Well, that's a bit better, but it still does not justify turning securityfs into procfs-like mess... when solution is so easy. Just use one value per file.
-- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
| |