lkml.org 
[lkml]   [2009]   [Mar]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [GIT PULL] Microblaze initial pack
Ingo Molnar wrote:
> * Ingo Molnar <mingo@elte.hu> wrote:
>
>
>> I have noticed one relatively big (but easily fixable) commit
>> structure problem in this tree.
>>
>> All of the commits have these tags:
>>
>> Reviewed-by: Stephen Neuendorffer <stephen.neuendorffer@xilinx.com>
>> Acked-by: John Linn <john.linn@xilinx.com>
>> Acked-by: John Williams<john.williams@petalogix.com>
>>
>
> I forgot to mention that in any case _your_ signoff as the submitter
> of this tree should be in all commits as well.
>
> So for example this (sample) chain would be fine:
>
> Reviewed-by: Stephen Neuendorffer <stephen.neuendorffer@xilinx.com>
> Acked-by: John Linn <john.linn@xilinx.com>
> Acked-by: John Williams<john.williams@petalogix.com>
> Signed-off-by: Michal Simek <monstr@monstr.eu>
>
> It's not enough to be listed as the author in the commit. (In any
> case please see Documentation/SubmittingPatches and the DCO 1.1.)
>
I add my name there too.

> Also, a minor stylistic detail, please fix this:
>
> John Williams<john.williams@petalogix.com>
>
> to:
>
> John Williams <john.williams@petalogix.com>
>
I fixed that space problem.

Thanks,
Michal
> Thanks,
>
> Ingo
> --
> To unsubscribe from this list: send the line "unsubscribe linux-arch" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>


--
Michal Simek, Ing. (M.Eng)
PetaLogix - Linux Solutions for a Reconfigurable World
w: www.petalogix.com p: +61-7-30090663,+42-0-721842854 f: +61-7-30090663



\
 
 \ /
  Last update: 2009-03-27 12:29    [W:0.179 / U:0.576 seconds]
©2003-2014 Jasper Spaans. Advertise on this site