Messages in this thread | | | Date | Fri, 27 Mar 2009 07:42:58 -0300 | From | Mauro Carvalho Chehab <> | Subject | Re: [PATCH] gspca: add missing .type field check in VIDIOC_G_PARM |
| |
On Thu, 19 Mar 2009 17:47:13 -0700 (PDT) Trent Piepho <xyzzy@speakeasy.org> wrote:
> On Thu, 19 Mar 2009, [UTF-8] Németh Márton wrote: > > The gspca webcam driver does not check the .type field of struct v4l2_streamparm. > > This field is an input parameter for the driver according to V4L2 API specification, > > revision 0.24 [1]. Add the missing check. > > I think this check could go in the v4l2 core too. It already does a > similar check for QUERYBUF, QBUF, DQBUF, etc. If the driver doesn't > provide a method for ->vidioc_try_fmt_foo() then the v4l2 core will reject > a call with .type == V4L2_BUF_TYPE_foo. > > It seems like it should be ok to do this for S_PARM and G_PARM too.
I agree. Could you provide such patch?
Cheers, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |