Messages in this thread | | | Date | Fri, 27 Mar 2009 07:11:43 -0300 | From | Mauro Carvalho Chehab <> | Subject | Re: [PATCH] radio-mr800.c: Missing mutex include |
| |
On Wed, 18 Mar 2009 00:42:08 +0300 Alexey Klimov <klimov.linux@gmail.com> wrote:
> On Tue, 2009-03-17 at 22:00 +0100, Alessio Igor Bogani wrote: > > radio-mr800.c uses struct mutex, so while <linux/mutex.h> seems to be > > pulled in indirectly by one of the headers it already includes, the > > right thing is to include it directly. > > > Hello, Alessio > > Patch looks okay for my eyes. > If it useful it should be applied. > > Thank you! > > Mauro, if patch is okay please apply it. > If you need my ack - here it is: > Acked-by: Alexey Klimov <klimov.linux@gmail.com>
If the mutex.h were already included by another kernel header, I don't see why to include it again. If a later patch remove the mutex.h from the header, then the patch author should take care of this change anyway.
Cheers, Mauro
| |