lkml.org 
[lkml]   [2009]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Subjectbug in drivers/edac/edac_core.h pci_write_bits32()
Date
From
2.6.29 and previous versions seem to contain this bug which I found just
eyeballing the code:

static inline void pci_write_bits32(struct pci_dev *pdev, int offset,
u32 value, u32 mask)
{
if (mask != 0xffff) {
u32 buf;

pci_read_config_dword(pdev, offset, &buf);
value &= mask;
buf &= ~mask;
value |= buf;
}

pci_write_config_dword(pdev, offset, value);
}

I'm pretty sure that "if" statement should be:

if (mask != 0xffffffff) {

Please copy my email address in any response as I do not subscribe.

Thanks,

Jeff Haran
Brocade


\
 
 \ /
  Last update: 2009-03-27 01:17    [W:0.034 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site