Messages in this thread | | | Subject | Re: [PATCH -tip] x86: unification of cpu/bugs.c | From | Jaswinder Singh Rajput <> | Date | Thu, 26 Mar 2009 19:59:54 +0530 |
| |
On Thu, 2009-03-26 at 15:12 +0100, Robert Richter wrote: > > +/* > > + * Check various bugs > > + */ > > +static void __init check_various_bugs(void) > > +{ > > + check_config(); > > + check_fpu(); > > + check_hlt(); > > + check_popad(); > > +
This is applicable to 32 bit only. right ?
> > + init_utsname()->machine[1] = > > + '0' + (boot_cpu_data.x86 > 6 ? 6 : boot_cpu_data.x86); >
hmm. this can be common.
> Did you evaluate why these functions are 32 bit only? Same applies to > 64 bit below. It seems this is not a unification and instead only some > move-around of code. >
Thanks for pointing.
-- JSR
| |