Messages in this thread | | | Subject | Re: [PATCH] module: Kill warning: label 'free_init' defined but not used | From | Jaswinder Singh Rajput <> | Date | Thu, 26 Mar 2009 01:52:30 +0530 |
| |
On Wed, 2009-03-25 at 21:05 +0100, Geert Uytterhoeven wrote: > On Wed, Mar 25, 2009 at 20:54, Jaswinder Singh Rajput > <jaswinder@kernel.org> wrote: > > On Wed, 2009-03-25 at 20:43 +0100, Geert Uytterhoeven wrote: > >> On m68k (which doesn't do SMP), I get: > >> > >> | kernel/module.c:2291: warning: label 'free_init' defined but not used > >> > >> which was introduced by commit 6e2b75740bed35df98b8113300579e13ed2ce848 > >> ("module: fix refptr allocation and release order"). > >> Move the label inside the #ifdef, as the goto is protected by the same #ifdef. > >> > >> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> > >> --- > > > > AFAIK, it is already fixed in -tip: > > http://git.kernel.org/?p=linux/kernel/git/x86/linux-2.6-tip.git;a=commit;h=67f5ca081c6ace125e8ccc76b8a7d99b091abaa7 > > Interesting, as I noticed the problem in today's linux-next. > http://kisskb.ellerman.id.au/kisskb/buildresult/271602/ > Or am I caught again by fake warnings from the bisection process? >
Yes, you are right linux-next is still having this problem.
You are the third guy who came with this fix.
Two of them are already applied in -tip and Rusty's tree:
-----------> On Wed, 2009-03-25 at 11:35 +1030, Rusty Russell wrote: > On Wednesday 25 March 2009 02:37:19 Américo Wang wrote: > > > > Label 'free_init' is only used when defined(CONFIG_MODULE_UNLOAD) && > > defined(CONFIG_SMP), so move it inside to shut up gcc. > > Thanks, applied! > Rusty. <-----------
May be you can also try linux-next tree ;-)
-- JSR
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |