lkml.org 
[lkml]   [2009]   [Mar]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 3/5] blktrace: fix off-by-one bug
    Li Zefan wrote:
    >>> - if (unlikely(what == 0 || what > ARRAY_SIZE(what2act)))
    >>> + if (unlikely(what == 0 || what >= ARRAY_SIZE(what2act)))
    >> ah, nice. How did you notice - did we miss "remap" events due to
    >> this bug?
    >>

    forgot to mention, we didn't miss any "remap" events.

    >
    > By code review, but we can get NULL dereference bug if we receive an
    > "abort" event, this event may be generated only when using device-mapper.
    >

    and not NULL dereference, but accessing invalid memory.

    what2act["abort"]->print(...)

    and "abort" == ARRAY_SIZE(what2act).

    > We don't print out this event currently, neither does the userspace
    > blktrace, which should be fixed.
    >




    \
     
     \ /
      Last update: 2009-03-24 09:43    [W:0.021 / U:59.224 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site