lkml.org 
[lkml]   [2009]   [Mar]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 2/5] blktrace: fix wrong calculation of RWBS
    Trace categories are the upper 16 bits, not the lower 16 bits.

    Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
    ---
    kernel/trace/blktrace.c | 13 +++++++------
    1 files changed, 7 insertions(+), 6 deletions(-)

    diff --git a/kernel/trace/blktrace.c b/kernel/trace/blktrace.c
    index 1ffcbd4..9af4143 100644
    --- a/kernel/trace/blktrace.c
    +++ b/kernel/trace/blktrace.c
    @@ -922,23 +922,24 @@ static void blk_unregister_tracepoints(void)
    static void fill_rwbs(char *rwbs, const struct blk_io_trace *t)
    {
    int i = 0;
    + int tc = t->action >> BLK_TC_SHIFT;

    - if (t->action & BLK_TC_DISCARD)
    + if (tc & BLK_TC_DISCARD)
    rwbs[i++] = 'D';
    - else if (t->action & BLK_TC_WRITE)
    + else if (tc & BLK_TC_WRITE)
    rwbs[i++] = 'W';
    else if (t->bytes)
    rwbs[i++] = 'R';
    else
    rwbs[i++] = 'N';

    - if (t->action & BLK_TC_AHEAD)
    + if (tc & BLK_TC_AHEAD)
    rwbs[i++] = 'A';
    - if (t->action & BLK_TC_BARRIER)
    + if (tc & BLK_TC_BARRIER)
    rwbs[i++] = 'B';
    - if (t->action & BLK_TC_SYNC)
    + if (tc & BLK_TC_SYNC)
    rwbs[i++] = 'S';
    - if (t->action & BLK_TC_META)
    + if (tc & BLK_TC_META)
    rwbs[i++] = 'M';

    rwbs[i] = '\0';
    --
    1.5.4.rc3


    \
     
     \ /
      Last update: 2009-03-24 09:07    [W:0.021 / U:0.616 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site