lkml.org 
[lkml]   [2009]   [Mar]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
SubjectBUG in 2.6.29 final: broken network connection
Date
Hi everybody,

ftp, ping, IP forwarding, IP masquerading etc., in short: everything having to
do with networking is broken using kernel 2.6.29.

My thousand thanks for that again go to Mr. David S. Miller, kernel
contributor of the netdev section, who again and again is adding his SOB under
untested crap code that itself breaks networking hardware by reaching the
kernel mainline via git patches.

In the past exactly that happened again and again, and it is particularly Mr.
David S. Miller himself who, proven by facts, is not willing to learn to stay
away from sending in malicious code via the git path.
I am really wondering why Linus Torvalds is still trusting him, as it is a
fact that not everybody can send in code just like that, i. e. without
restrictions.

It cost me almost 1 complete day (and again I do state that this is not the
first time that some unqualified hacker operating with the responsibility of Mr.
David S. Miller deeply sucks and steals my nerves and wastes my time) to find
out that the following patch needs to be reverted to make networking services
in 2.6.29 final available again for everybody.

--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -2588,9 +2588,9 @@ static int process_backlog(struct napi_struct *napi, int
quota)
local_irq_disable();
skb = __skb_dequeue(&queue->input_pkt_queue);
if (!skb) {
- __napi_complete(napi);
local_irq_enable();
- break;
+ napi_complete(napi);
+ goto out;
}
local_irq_enable();

@@ -2599,6 +2599,7 @@ static int process_backlog(struct napi_struct *napi, int
quota)

napi_gro_flush(napi);

+out:
return work;
}

@@ -2671,7 +2672,7 @@ void netif_napi_del(struct napi_struct *napi)
struct sk_buff *skb, *next;

list_del_init(&napi->dev_list);
- kfree(napi->skb);
+ kfree_skb(napi->skb);

for (skb = napi->gro_list; skb; skb = next) {
next = skb->next;
Best wishes

Uwe



\
 
 \ /
  Last update: 2009-03-24 18:19    [from the cache]
©2003-2011 Jasper Spaans