Messages in this thread | | | Subject | Re: ftruncate-mmap: pages are lost after writing to mmaped file. | From | Peter Zijlstra <> | Date | Tue, 24 Mar 2009 15:56:03 +0100 |
| |
On Tue, 2009-03-24 at 15:47 +0100, Jan Kara wrote: > > Or we could implement ext3_mkwrite() to allocate buffers already when we > make page writeable. But it costs some performace (we have to write page > full of zeros when allocating those buffers, where previously we didn't > have to do anything) and it's not trivial to make it work if pagesize > > blocksize (we should not allocate buffers outside of i_size so if i_size > = 1024, we create just one block in ext3_mkwrite() but then we need to > allocate more when we extend the file).
I think this is the best option, failing with SIGBUS when we fail to allocate blocks seems consistent with other filesystems as well.
| |