Messages in this thread | | | Date | Tue, 24 Mar 2009 15:44:19 +0100 | From | Michal Simek <> | Subject | Re: [PATCH 44/57] microblaze_v7: termbits.h termios.h |
| |
Arnd Bergmann wrote: > On Tuesday 24 March 2009, Michal Simek wrote: >>> I haven't gotten around to posting them for review, but I still think >>> it would be great if we can at least make sure they are identical >>> so we can remove your versions as soon as we have the asm-generic ones. >> I tested it some min ago. I just take your termios.h and termbits.h from >> asm-generic folder. I miss there only #include <asm/uaccess.h> in termion.h. >> >> Compilation is OK and kernel works with your files too. For me is easy to use >> your version. If they are there, I'll use them. > > Ok. I did not just mean these specific files, but all the headers in > general. I assume that you have not had a chance to look into the > other header files, which is ok. Remis is currently cleaning up bits > of the generic header files in Linux based on my work, and I asked > him to look into your tree to see how much can be shared. > > Note that there is a problem of binary compatibility with certain headers. > If e.g. the constants from termbits.h or some data structures slightly > change, user space will still compile but no longer be compatible > with other kernel versions, so this needs to be done very carefully.
As John wrote. It is completely new kernel and we do (will do) new toolchain against new headers. I am open to use all generic approaches which will be in kernel.
Thanks, Michal
> > Arnd <><
-- Michal Simek, Ing. (M.Eng) w: www.monstr.eu p: +42-0-721842854
| |