lkml.org 
[lkml]   [2009]   [Mar]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
DateTue, 24 Mar 2009 12:20:27 +0100
FromMichal Simek <>
SubjectRe: [PATCH 44/57] microblaze_v7: termbits.h termios.h
Arnd Bergmann wrote:
> On Wednesday 18 March 2009, monstr@monstr.eu wrote:
>> From: Michal Simek <monstr@monstr.eu>
>>
>>
>> Signed-off-by: Michal Simek <monstr@monstr.eu>
>> ---
>> arch/microblaze/include/asm/termbits.h | 203 ++++++++++++++++++++++++++++++++
>> arch/microblaze/include/asm/termios.h | 88 ++++++++++++++
>> 2 files changed, 291 insertions(+), 0 deletions(-)
>> create mode 100644 arch/microblaze/include/asm/termbits.h
>> create mode 100644 arch/microblaze/include/asm/termios.h
>
> Did you take at the header files I have in git://git.kernel.org/pub/scm/linux/kernel/git/arnd/playground.git/#generic-headers?


> I haven't gotten around to posting them for review, but I still think
> it would be great if we can at least make sure they are identical
> so we can remove your versions as soon as we have the asm-generic ones.

I tested it some min ago. I just take your termios.h and termbits.h from
asm-generic folder. I miss there only #include <asm/uaccess.h> in termion.h.

Compilation is OK and kernel works with your files too. For me is easy to use
your version. If they are there, I'll use them.

Thanks,
Michal


> Arnd <><


--
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854


\
 
 \ /
  Last update: 2009-03-24 12:23    [from the cache]
©2003-2010