lkml.org 
[lkml]   [2009]   [Mar]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/5] tracing/events: make the filter files writable
On Mon, Mar 23, 2009 at 09:25:56AM +0100, Ingo Molnar wrote:
>
> * Frederic Weisbecker <fweisbec@gmail.com> wrote:
>
> > We need the filter files to be writable, the current
> > filter file permissions make are only set readable.
> >
> > Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
> > ---
> > kernel/trace/trace_events.c | 4 ++--
> > 1 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c
> > index 594d78a..19f61dd 100644
> > --- a/kernel/trace/trace_events.c
> > +++ b/kernel/trace/trace_events.c
> > @@ -706,7 +706,7 @@ event_subsystem_dir(const char *name, struct dentry *d_events)
> >
> > system->preds = NULL;
> >
> > - entry = debugfs_create_file("filter", 0444, system->entry, system,
> > + entry = debugfs_create_file("filter", 0644, system->entry, system,
> > &ftrace_subsystem_filter_fops);
> > if (!entry)
> > pr_warning("Could not create debugfs "
> > @@ -769,7 +769,7 @@ event_create_dir(struct ftrace_event_call *call, struct dentry *d_events)
> > }
> > }
> >
> > - entry = debugfs_create_file("filter", 0444, call->dir, call,
> > + entry = debugfs_create_file("filter", 0644, call->dir, call,
>
> Interesting. Yesterday i tried the filter files and they worked - i
> was able to create a 'comm == bash' filter for example. Does debugfs
> ignore permissions perhaps?
>
> Ingo


That's the second patch I see this week wich proposes a 444 file supposed
to be writable.
Usually it shouldn't even have been testable, so yes I think there is a
little problem.



\
 
 \ /
  Last update: 2009-03-23 09:35    [W:0.051 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site