Messages in this thread | | | From | Rusty Russell <> | Subject | Re: [git-pull -tip] x86: cleanup patches 20090322 | Date | Mon, 23 Mar 2009 18:45:04 +1030 |
| |
On Monday 23 March 2009 07:22:56 Jaswinder Singh Rajput wrote: > x86: e820.h fix various signedness issues in setup.c and e820.c
Wouldn't fixing the users be better than changing the header? Esp. since it could well now cause similar warnings in userspace programs.
> struct e820map { > - __u32 nr_map; > + __s32 nr_map; > struct e820entry map[E820_X_MAX]; > };
This number can't be negative!
Cheers, Rusty.
| |