Messages in this thread | | | Date | Mon, 23 Mar 2009 08:04:55 +0000 | From | Jarek Poplawski <> | Subject | Re: [PATCH] netconsole: fix BUG during net device "upping" |
| |
On 23-03-2009 05:21, David Miller wrote: > From: Matt Mackall <mpm@selenic.com> > Date: Sun, 22 Mar 2009 20:20:58 -0500 > >> On Sun, 2009-03-22 at 12:02 +0100, Marcin Slusarz wrote: >>> When ndo_open (eg skge_up) function printks something, netconsole decides >>> it can use this device because it checks state only (netif_running) which is >>> set before ndo_open. Check device flags too. >> That's fairly unfortunate semantics for netif_running. But if Dave >> agrees that it's reasonable for that to be set to true at this point in >> time, then I guess we'll go with it. > > These kind of printk's simply are not allowed, we've removed such > printk's from other driver ->open() methods to fix this problem and > that's what should be done here.
What is the rationale of this decision? printk is a basic tool, especially designed to work in as many places as possible, and netconsole is rather something secondary (sorry Matt)?!
Jarek P.
| |