Messages in this thread | | | Date | Mon, 23 Mar 2009 09:33:17 -0400 (EDT) | From | Christoph Lameter <> | Subject | Re: [PATCH -mm 1/6] slab: introduce __kfree_rcu |
| |
On Mon, 23 Mar 2009, Pekka Enberg wrote:
> > +static inline void *portion_to_obj(void *portion) > > +{ > > + struct page *page = virt_to_head_page(portion); > > + struct slab *slab = page_get_slab(page); > > + struct kmem_cache *cache = page_get_cache(page); > > + unsigned int offset = portion - slab->s_mem; > > + unsigned int index = offset / cache->buffer_size; > > + > > + return index_to_obj(cache, slab, index); > > +} > > A minor nit: I think this would be more readable if you separated > variable declarations from the initializations. Also, you can probably > drop the inline from the function declaration and let GCC decide what to > do.
Thats debatable. I find the setting up a number of variables that are all dependend in the above manner very readable. They are usually repetitive. Multiple functions use similar initializations.
| |