lkml.org 
[lkml]   [2009]   [Mar]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: [PATCH -tip] cpuacct: per-cgroup utime/stime statistics - v4
    On Mon, 23 Mar 2009 10:05:38 +0530
    Bharata B Rao <bharata@linux.vnet.ibm.com> wrote:

    > Hi Ingo,
    >
    > Here is the v4 of the cpuacct statistics patch to obtain per-cgroup
    > system and user times with appropriate tags and complete changelog.
    > This applies against the latest -tip plus the cpuacct hierarchy fix v2
    > which I posted just now. Could you please include this in -tip ?
    >
    > Changelog:
    >
    > v4
    > - Remove comments in cpuacct_update_stats() which explained why rcu_read_lock()
    > was needed (as per Peter Zijlstra's review comments).
    > - Don't say that percpu_counter_read() is broken in Documentation/cpuacct.txt
    > as per KAMEZAWA Hiroyuki's review comments.
    >
    Broken -> isn't safe ? no difference ;)
    Can't this help you ?


    Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
    ---
    Index: mmotm-2.6.29-Mar21/include/linux/percpu_counter.h
    ===================================================================
    --- mmotm-2.6.29-Mar21.orig/include/linux/percpu_counter.h
    +++ mmotm-2.6.29-Mar21/include/linux/percpu_counter.h
    @@ -62,6 +62,16 @@ static inline s64 percpu_counter_read(st
    return fbc->count;
    }

    +static inline s64 percpu_counter_read_safe(struct percpu_counter *fbc)
    +{
    + s64 ret;
    +
    + spin_lock(&fbc->lock);
    + ret = fbc->count;
    + spin_unlock(&fbc->lock);
    + return ret;
    +}
    +
    /*
    * It is possible for the percpu_counter_read() to return a small negative
    * number for some counter which should never be negative.
    @@ -114,6 +124,11 @@ static inline s64 percpu_counter_read(st
    return fbc->count;
    }

    +static inline s64 percpu_counter_read_safe(struct percpu_counter *fbc)
    +{
    + return fbc->count;
    +}
    +
    static inline s64 percpu_counter_read_positive(struct percpu_counter *fbc)
    {
    return fbc->count;


    \
     
     \ /
      Last update: 2009-03-23 05:59    [W:0.025 / U:30.248 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site