lkml.org 
[lkml]   [2009]   [Mar]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 01/13] md/raid6: move raid6 data processing to raid6_pq.ko
    From
    On Thu, Mar 19, 2009 at 1:09 PM, Andre Noll <maan@systemlinux.org> wrote:
    > On 12:20, Dan Williams wrote:
    >> Move the raid6 data processing routines into a standalone module
    >> (raid6_pq) to prepare them to be called from async_tx wrappers and other
    >> non-md drivers/modules.  This precludes a circular dependency of raid456
    >> needing the async modules for data processing while those modules in
    >> turn depend on raid456 for the base level synchronous raid6 routines.
    >>
    >> To support this move:
    >> 1/ The exportable definitions in raid6.h move to include/linux/raid/pq.h
    >
    > As raid*.h and md.h have been moved to drivers/md recently, pq.h
    > should probably live there as well.

    Not in this case. pq.h is analogous to xor.h currently in
    include/linux/raid/. I.e. just the data processing symbols that are
    used by modules outside of drivers/md/.

    >> +#define time_before(x, y) ((x) < (y))
    >
    > This macro seems to have no users (and a strange name).
    >

    It's used a few lines down in the same file. It allows raid6algos.c
    to be compiled for the userspace test (drivers/md/raid6test/) where we
    do not have jiffies.h.

    Regards,
    Dan
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2009-03-22 18:25    [W:0.033 / U:30.500 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site