Messages in this thread | | | Date | Mon, 2 Mar 2009 16:01:11 +0000 | From | Mark Brown <> | Subject | Re: [PATCH] checkpatch: Warn on empty commit log bodies |
| |
On Mon, Mar 02, 2009 at 04:15:49PM +0100, Stefan Richter wrote: > Mark Brown wrote:
> > Andrew Morton is one of them but not the only one. Like I say, I don't
> As far as I have observed, akpm's (Cc'd now) complaints are about > patches whose impact or benefit etc. are insufficiently explained --- > which is an issue on a higher level than pure formalism. I believe I > too have seen the term "unchangelogged" (as you mentioned) in one of > those discussions but I associated lack of information with it rather > than a violation of a formalism.
The terminology and comments about normally skipping these "unchangelogged" patches create a very different impression. Obviously, there's going to be a crossover between the two cases.
> I still say there are some straightforward changes which /can/ be well > explained in a single line (which would be the title line). Still, by > far the most changes, including several kinds of janitorial changes, > require more explanation than that. At which level a changelog should
Sure, this is all very standard stuff.
> It is not trivial to give general advice on that, and it is impossible > to encode even simple tests for the quality of a changelog in a script > like checkpatch.
As I've said already on a number of occasions the patch was purely intended to catch the case where there was no body in the patch log, which appeared to be something that was being specifically objected to.
| |