Messages in this thread | | | Date | Mon, 2 Mar 2009 16:10:07 +0100 | From | Pavel Machek <> | Subject | Re: [PATCH 4/5] lis3: solve dependency between core and ACPI |
| |
Hi!
> This solves the dependency between lis3lv02d.[ch] and ACPI specific > methods. It introduces a ->bus_priv pointer to the device struct which > is casted to 'struct acpi_device' in the ACIP layer. Changed hp_accel.c > accordingly.
Looks okay to me. I did the basic split but -- having only single client -- did not really have motivation to finish it.
> This also moves the read_8() and read_16() routines from hp_accel.c to > lis3lv02d.c as they are not specific to ACPI.
These would be slightly better done as separate patch, but I guess its okay...
> Signed-off-by: Daniel Mack <daniel@caiaq.de>
Acked-by: Pavel Machek <pavel@ucw.cz>
-- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
| |