Messages in this thread | | | Date | Mon, 2 Mar 2009 16:25:22 -0700 | Subject | Re: [PATCH] iop-adma, dmaengine: misplaced curly brackets? | From | Dan Williams <> |
| |
On Wed, Feb 25, 2009 at 5:56 AM, Roel Kluin <roel.kluin@gmail.com> wrote: > I observed this by code inspection, and it was not tested in any way, > but aren't the curly brackets below wrong? > > please review. > ------------------------------>8-------------8<--------------------------------- > Misplaced curly brackets. > > Signed-off-by: Roel Kluin <roel.kluin@gmail.com> > ---
Yes, static analysis caught this error here recently as well. I have applied your patch with a fixed up changelog:
commit d2076514c9ea68e7fef21158c1cdb8b244bfe5f2 Author: Roel Kluin <roel.kluin@gmail.com> Date: Wed Feb 25 13:56:21 2009 +0100
iop-adma, mv_xor: fix mem leak on self-test setup failure
iop_adma_zero_sum_self_test has the brackets in the wrong place for the setup failure deallocation path. This error was duplicated in mv_xor_xor_self_test.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Thanks, Dan
| |