lkml.org 
[lkml]   [2009]   [Mar]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH][retry 2] Conform L3 Cache Index Disable to Linuxstandards From: Eric Lammerts <>

    * Langsdorf, Mark <mark.langsdorf@amd.com> wrote:

    > > > > Add ABI Documentation entry and fix some /sys directory formating
    > > > > issues with the L3 Cache Index Disable feature for future AMD
    > > > > processors. __Add a check to disable it for family 0x10 models
    > > > > that do not support it yet.
    > > >
    > > > x86_64 allnoconfig:
    > > >
    > > > arch/x86/kernel/cpu/intel_cacheinfo.c:556: warning:
    > > 'free_cache_attributes' defined but not used
    > > > arch/x86/kernel/cpu/intel_cacheinfo.c:596: warning:
    > > 'detect_cache_attributes' defined but not used
    >
    > My code doesn't modify either of these functions, so
    > I'm not causing the regression.

    The more serious problem is what i reported, that your patch
    triggers this build failure:

    arch/x86/kernel/built-in.o: In function `store_cache_disable':
    intel_cacheinfo.c:(.text+0xd322): undefined reference to `k8_northbridges'
    arch/x86/kernel/built-in.o: In function `show_cache_disable':
    intel_cacheinfo.c:(.text+0xd52c): undefined reference to `k8_northbridges'

    so i've excluded it from tip:master for now. Please resubmit a
    fixed patch.

    Ingo


    \
     
     \ /
      Last update: 2009-03-02 21:05    [W:4.904 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site