Messages in this thread |  | | | Date | Mon, 2 Mar 2009 10:01:58 -0800 | | From | Andrew Morton <> | | Subject | Re: [PATCH] checkpatch: Warn on empty commit log bodies |
| |
On Mon, 02 Mar 2009 16:15:49 +0100 Stefan Richter <stefanr@s5r6.in-berlin.de> wrote:
> Mark Brown wrote: > > On Sat, Feb 28, 2009 at 09:53:57PM -0500, Theodore Tso wrote: > >> Who's been complaining? I can certainly tell you I'll complain in the > >> opposite direction, but that's because it actually causes me more work > > > > Andrew Morton is one of them but not the only one. Like I say, I don't > > want to claim that my changelogs are always ideal here, it was mostly > > the specific language used that made me think of doing this. > > As far as I have observed, akpm's (Cc'd now) complaints are about > patches whose impact or benefit etc. are insufficiently explained --- > which is an issue on a higher level than pure formalism. I believe I > too have seen the term "unchangelogged" (as you mentioned) in one of > those discussions but I associated lack of information with it rather > than a violation of a formalism.
Oh absolutely. Quite often the changelog body contains no information which wasn't in the title, so there's no need for a body.
I think what triggered this was a patch from Mark which had no changelog and which had me sitting there wondering wtf it does, whether we need it in 2.6.29, whether we need it in 2.6.28.x and earlier and me not having the foggiest clue then getting grumpy.
|  |