Messages in this thread | | | Date | Thu, 19 Mar 2009 13:43:34 -0700 (PDT) | From | Trent Piepho <> | Subject | Re: [PATCH v4 08/12] PCI: Introduce /sys/bus/pci/devices/.../remove |
| |
On Thu, 19 Mar 2009, Alex Chiang wrote: > * Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>: > >> + pci_remove_bus_device(pdev); > >> + if (bridge && list_empty(&pdev->bus->devices)) > >> + pci_remove_bus(pdev->bus); > > > > I cannot understand the above two lines. Could you explain > > what it intend? > > If the user says: > > echo 1 > /sys/bus/pci/devices/.../remove > > And that device is a bridge, then we need to specifically call > pci_remove_bus as well, to actually remove the bus itself. > Without it, pci_bus_remove_device() will remove all of its > children (and subordinate buses) in a depth-first manner, but we > will never actually remove the bus that the user specified.
Did this end up being the source of the pci resource assignment warnings that were produced when re-adding a bridge that was removed?
| |